[asterisk-dev] [Code Review] 2560: chan_pjsip "progressinband" option

[svnbot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2560/
-----------------------------------------------------------

(Updated May 28, 2013, 9:19 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 389846


Repository: Asterisk


Description
-------

This change adds a progressinband equivalent option to chan_pjsip named "inband_progress". If set to yes ringing will be sent inband using a 183 Session Progress response and RTP. If set to no then the normal sending of 180 Ringing will occur.


Diffs
-----

  /team/group/pimp_my_sip/channels/chan_gulp.c 389491 
  /team/group/pimp_my_sip/include/asterisk/res_sip.h 389491 
  /team/group/pimp_my_sip/res/res_sip.c 389491 
  /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 389491 

Diff: https://reviewboard.asterisk.org/r/2560/diff/


Testing
-------

Turned option on, confirmed 183 + media. Turned option off, confirmed 180.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130528/15492ded/attachment.htm>