[asterisk-dev] Where are codec_opus and format_vp8 in menuselect?
Lorenzo Miniero
lminiero at gmail.com
Tue May 28 00:34:00 CDT 2013
Hi James,
Bootstrap errors like those usually suggest that some packages providing
macros are missing. Do you have autoconf, automake and pkg-config installed?
Lorenzo
Il giorno 28/mag/2013 02:11, "James Mortensen" <
james.mortensen at voicecurve.com> ha scritto:
> Hi Lorenzo,
>
> I tried applying the patch and running bootstrap.sh against Asterisk
> 11.1.2, just to use that as a sanity check, and I still see the same issues:
>
> root at ip-10-188-135-200:/mnt/src/asterisk-11.1.2# ./bootstrap.sh
> Generating the configure script ...
> configure.ac:102: error: possibly undefined macro: AC_DEFINE
> If this token and others are legitimate, please use m4_pattern_allow.
> See the Autoconf documentation.
> root at ip-10-188-135-200:/mnt/src/asterisk-11.1.2#
>
> How did you install libopus? I grabbed 1.0.2, the latest version, from
> here? http://www.opus-codec.org/downloads/ and then followed their
> instructions for building and installing it.
>
> James
>
>
> On Mon, May 27, 2013 at 5:04 PM, James Mortensen <
> james.mortensen at voicecurve.com> wrote:
>
>> Also, I want to add that applying the patch is successful, but due to the
>> version differences there is some offset:
>>
>> root at ip-10-188-135-200:/mnt/src/asterisk-11.4.0# patch -p1 -u <
>> asterisk_opus+vp8.diff
>> patching file build_tools/menuselect-deps.in
>> patching file channels/chan_sip.c
>> Hunk #1 succeeded at 7757 (offset 33 lines).
>> Hunk #2 succeeded at 11045 (offset 46 lines).
>> Hunk #3 succeeded at 11084 (offset 46 lines).
>> Hunk #4 succeeded at 11151 (offset 46 lines).
>> Hunk #5 succeeded at 12756 (offset 107 lines).
>> Hunk #6 succeeded at 12789 (offset 107 lines).
>> patching file codecs/codec_opus.c
>> patching file codecs/ex_opus.h
>> patching file configure.ac
>> Hunk #2 succeeded at 2119 (offset 32 lines).
>> patching file formats/format_vp8.c
>> patching file include/asterisk/format.h
>> patching file main/channel.c
>> Hunk #1 succeeded at 914 (offset 5 lines).
>> patching file main/format.c
>> Hunk #5 succeeded at 1083 (offset -1 lines).
>> patching file main/frame.c
>> patching file main/rtp_engine.c
>> Hunk #1 succeeded at 2289 (offset 21 lines).
>> Hunk #2 succeeded at 2333 (offset 21 lines).
>> patching file makeopts.in
>> Hunk #1 succeeded at 262 (offset 1 line).
>> patching file res/res_rtp_asterisk.c
>> Hunk #2 succeeded at 349 (offset 6 lines).
>> Hunk #3 succeeded at 2620 (offset 16 lines).
>> Hunk #4 succeeded at 2706 (offset 16 lines).
>>
>>
>> From what I understand, as long as there are no errors, the patch should
>> theoretically have been applied. Hope this helps!
>>
>> James
>>
>>
>> On Mon, May 27, 2013 at 4:53 PM, James Mortensen <
>> james.mortensen at voicecurve.com> wrote:
>>
>>> Hi Lorenzo,
>>>
>>> Please disregard my last set of issues. The problem was something to do
>>> with an unrelated server bug. I'm still trying to get the patch to work on
>>> 11.4.0 since that is the latest stable release of Asterisk, and I'm hoping
>>> I can provide you with enough helpful information for you to move forward.
>>>
>>> When I run the bootstrap.sh command to generate the configure script, I
>>> did see the following error:
>>>
>>> # ./bootstrap.sh
>>> Generating the configure script ...
>>> configure.ac:102: error: possibly undefined macro: AC_DEFINE
>>> If this token and others are legitimate, please use
>>> m4_pattern_allow.
>>> See the Autoconf documentation.
>>>
>>> I ran apt-get update && apt-get upgrade and then reran the bootstrap.sh,
>>> which was a success. I'm not sure if that mattered or not, but there were
>>> no warnings or errors the second time around.
>>>
>>> But then running the configure script, I get the following compile
>>> errors:
>>>
>>> checking if "int foo = DAHDI_ECHOCANCEL_FAX_MODE" compiles using
>>> dahdi/user.h... no
>>> checking for getifaddrs() support... yes
>>> checking for timerfd support... yes
>>> checking for gsm_create in -lgsm... no
>>> ./configure: line 17995: syntax error near unexpected token `ILBC,'
>>> ./configure: line 17995: ` PKG_CHECK_MODULES(ILBC, libilbc,'
>>>
>>> I looked in the previous configure script, before running bootstrap.sh,
>>> and I don't see any instances of PKG_CHECK_MODULES or ILBC. That is an
>>> existing codec, I believe, so why would the opus codec require these
>>> additions?
>>>
>>> I am wondering if you happen to see anything that might be helpful here;
>>> otherwise, I plan to continue to dig into this and move forward as best I
>>> can.
>>>
>>> Thank you, and hope this helps!
>>> James
>>>
>>>
>>>
>>>
>>> On Mon, May 27, 2013 at 12:45 PM, Lorenzo Miniero <lminiero at gmail.com>wrote:
>>>
>>>> 2013/5/27 James Mortensen <james.mortensen at voicecurve.com>
>>>>
>>>>> In the instructions
>>>>> https://github.com/meetecho/asterisk-opus/blob/master/README.md, we
>>>>> see the following:
>>>>>
>>>>> "Make sure that codec_opus and format_vp8 are enabled in menuselect
>>>>> before going on. Besides, for better results, install the slin16 versions
>>>>> of the Asterisk sounds, which are not enabled by default."
>>>>>
>>>>> What part of the menuselect should we expect to find codec_opus and
>>>>> format_vp8? I'm trying to add this patch to Asterisk 11.4.0 and don't want
>>>>> to play guessing games if this isn't going to work. I checked in the
>>>>> "Codec Translators" section and I don't see those codec's listed.
>>>>>
>>>>> Also, if it helps, I see this when configuring opus from source:
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------
>>>>> opus 1.0.2: Automatic configuration OK.
>>>>>
>>>>> Compiler support:
>>>>>
>>>>> C99 var arrays: ................ yes
>>>>> C99 lrintf: .................... yes
>>>>> Alloca: ........................ yes
>>>>>
>>>>> General configuration:
>>>>>
>>>>> Floating point support: ........ yes
>>>>> Fast float approximations: ..... no
>>>>> Fixed point debugging: ......... no
>>>>> Custom modes: .................. no
>>>>> Assertion checking: ............ no
>>>>> Fuzzing: ....................... no
>>>>>
>>>>> API documentation: ............. no
>>>>>
>>>>> ------------------------------------------------------------------------
>>>>>
>>>>> Opus compiled on Ubuntu 12.04 without any errors or warnings.
>>>>>
>>>>> However, when patching Asterisk, I see the following:
>>>>>
>>>>> root at jamesasterisktest:/mnt/asteriskpersistent/src/asterisk-11.4.0#
>>>>> patch -p1 -u < asterisk_opus+vp8.diff
>>>>> patching file build_tools/menuselect-deps.in
>>>>> patching file channels/chan_sip.c
>>>>> Hunk #1 succeeded at 7757 (offset 33 lines).
>>>>> Hunk #2 succeeded at 11045 (offset 46 lines).
>>>>> Hunk #3 succeeded at 11084 (offset 46 lines).
>>>>> Hunk #4 succeeded at 11151 (offset 46 lines).
>>>>> Hunk #5 succeeded at 12756 (offset 107 lines).
>>>>> Hunk #6 succeeded at 12789 (offset 107 lines).
>>>>> patch: **** write error : No space left on device
>>>>>
>>>>> The drive has 2.3GB of available space, and the patch isn't that big.
>>>>>
>>>>>
>>>>> If any of this looks related to the patch issues, I'll try with
>>>>> 11.1.2. I just want to make sure the other pieces are in order and that
>>>>> I'm looking for things in menuselect in the right places.
>>>>>
>>>>>
>>>>
>>>> My guess is that the error you got prevented the patch from being
>>>> completely applied: most likely neither code_opus.c nor format_vp8.c were
>>>> created, and so they don't appear in menuselect. About Asterisk 11.4.0
>>>> compatibility, I'm not familiar with that version so I'm not sure if and
>>>> how it would work. If the menuselect syntax has not been changed in the
>>>> meanwhile it should find both the files without problems.
>>>>
>>>> Lorenzo
>>>>
>>>> Thank you!
>>>>>
>>>>> --
>>>>> James Mortensen
>>>>> Project Manager, VoiceCurve, Inc.
>>>>> 866-707-4590
>>>>> james.mortensen at voicecurve.com
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> James Mortensen
>>> Project Manager, VoiceCurve, Inc.
>>> 866-707-4590
>>> james.mortensen at voicecurve.com
>>>
>>
>>
>>
>> --
>> James Mortensen
>> Project Manager, VoiceCurve, Inc.
>> 866-707-4590
>> james.mortensen at voicecurve.com
>>
>
>
>
> --
> James Mortensen
> Project Manager, VoiceCurve, Inc.
> 866-707-4590
> james.mortensen at voicecurve.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130528/cfdf919b/attachment.htm>
More information about the asterisk-dev
mailing list