[asterisk-dev] [Code Review] 2566: autoservice_run ast_frfree missing when already out of mem

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2566/
-----------------------------------------------------------

(Updated May 25, 2013, 1:30 p.m.)


Review request for Asterisk Developers.


Changes
-------

Alternative solution with added question ;)


Repository: Asterisk


Description
-------

Hi, I'm trying to find the cause of an issue I encountered with a terrible lot of duplicated fax frames.

While browsing the code, I found the following hard to read code. It looks to me like there is a missing ast_frfree() in this off-nominal path when we're out of mem.


Diffs (updated)
-----

  /trunk/main/autoservice.c 389769 

Diff: https://reviewboard.asterisk.org/r/2566/diff/


Testing
-------

None whatsoever.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130525/3801588b/attachment.htm>