[asterisk-dev] [Code Review] 2565: Move Hold (and now Unhold) manager event into stasis.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2565/#review8711
-----------------------------------------------------------



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/2565/#comment17075>

    Everywhere you do an ast_queue_hold(chan, S_OR(ptr, NULL)) in this patch, you can replace the use of S_OR() with just the ptr.  The queue function effectively does the S_OR() internally.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2565/#comment17073>

    This doxygen comment is not needed since the channel.h prototype has the doxygen comment.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2565/#comment17074>

    This doxygen comment is not needed since the channel.h prototype has the doxygen comment.


- rmudgett


On May 23, 2013, 8:52 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2565/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 8:52 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21487
>     https://issues.asterisk.org/jira/browse/ASTERISK-21487
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This takes the Hold event out of the few channel drivers that supported it, and moved it into stasis, so that all channel drivers use it.
> 
> This also adds a new Unhold event, removing the On/Off status from the old Hold event.
> 
> 
> This also fixes a bug (NULL blobs didn't get sent) that would have happened with ast_queue_hangup() and possibly others, since it was affecting me here.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_dahdi.c 389616 
>   /trunk/channels/chan_h323.c 389616 
>   /trunk/channels/chan_iax2.c 389616 
>   /trunk/channels/chan_mgcp.c 389616 
>   /trunk/channels/chan_misdn.c 389616 
>   /trunk/channels/chan_motif.c 389616 
>   /trunk/channels/chan_sip.c 389616 
>   /trunk/channels/chan_skinny.c 389616 
>   /trunk/channels/chan_unistim.c 389616 
>   /trunk/channels/sig_analog.c 389616 
>   /trunk/channels/sig_pri.c 389616 
>   /trunk/include/asterisk/channel.h 389616 
>   /trunk/include/asterisk/stasis_channels.h 389616 
>   /trunk/main/channel.c 389616 
>   /trunk/main/manager_channels.c 389616 
>   /trunk/main/stasis_channels.c 389616 
>   /trunk/res/res_sip_sdp_rtp.c 389616 
> 
> Diff: https://reviewboard.asterisk.org/r/2565/diff/
> 
> 
> Testing
> -------
> 
> Verified that chan_sip and chan_pjsip send out the new Hold and Unhold events, with and/or without musicclass.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130523/c0e39907/attachment-0001.htm>