[asterisk-dev] [Code Review] 2547: Remove single event type restriction from res_sip_pubsub

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2547/
-----------------------------------------------------------

(Updated May 22, 2013, 9:29 p.m.)


Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

The pjsip subscription system has a restriction where only a single event type can be registered. Due to the way res_sip_pubsub has been architected this really doesn't matter as it is always called into and ultimately finds a respective handler among all registered. The change attached moves a bit of logic into res_sip_pubsub (adding of accept types to the global Accept header) and only registers an event type once. By doing so res_sip_pubsub now supports multiple modules registering the same event type.


Diffs (updated)
-----

  /team/group/pimp_my_sip/res/res_sip_pubsub.c 389491 

Diff: https://reviewboard.asterisk.org/r/2547/diff/


Testing
-------

Set MWI up, confirmed it works as expected still.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130522/30b45c31/attachment.htm>