[asterisk-dev] [Code Review] 2547: Remove single event type restriction from res_sip_pubsub

[Joshua Colp]

> On May 22, 2013, 4:43 p.m., Kevin Harwell wrote:
> > /team/group/pimp_my_sip/res/res_sip_pubsub.c, line 380
> > <https://reviewboard.asterisk.org/r/2547/diff/1/?file=38134#file38134line380>
> >
> >     Do we need to worry about removing the capability on unregister?

Unfortunately there are certain aspects of pjsip which do not provide a mechanism for removal, this is one of them. In a normal environment stuff doesn't get unloaded/loaded etc so I think it's fine.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2547/#review8689
-----------------------------------------------------------


On May 15, 2013, 10:15 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2547/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 10:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The pjsip subscription system has a restriction where only a single event type can be registered. Due to the way res_sip_pubsub has been architected this really doesn't matter as it is always called into and ultimately finds a respective handler among all registered. The change attached moves a bit of logic into res_sip_pubsub (adding of accept types to the global Accept header) and only registers an event type once. By doing so res_sip_pubsub now supports multiple modules registering the same event type.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/res/res_sip_pubsub.c 388882 
> 
> Diff: https://reviewboard.asterisk.org/r/2547/diff/
> 
> 
> Testing
> -------
> 
> Set MWI up, confirmed it works as expected still.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130522/c33d0ec8/attachment.htm>