[asterisk-dev] [Code Review] 2549: Add dial (begin / end) events to app_queue and app_followme

[Jason Parker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2549/
-----------------------------------------------------------

(Updated May 21, 2013, 2:56 p.m.)


Review request for Asterisk Developers.


Bugs: ASTERISK-21550 and ASTERISK-21551
    https://issues.asterisk.org/jira/browse/ASTERISK-21550
    https://issues.asterisk.org/jira/browse/ASTERISK-21551


Repository: Asterisk


Description
-------

Since they're silly, and don't use the dial API.

There is a change in app_dial that addresses an incorrect (backwards) begin event and a missing end event that I noticed.


Diffs (updated)
-----

  /trunk/apps/app_dial.c 389309 
  /trunk/apps/app_followme.c 389309 
  /trunk/apps/app_queue.c 389309 
  /trunk/include/asterisk/dial.h 389309 
  /trunk/main/dial.c 389309 

Diff: https://reviewboard.asterisk.org/r/2549/diff/


Testing
-------

For app_queue, I get the same number of begin events as I do end events.  I get the number I would expect in all cases I've tried (including the forwarding logic).


Thanks,

Jason Parker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130521/0748fc02/attachment.htm>