[asterisk-dev] [Code Review] 2558: Eliminate most calls to ast_channel_internal_bridged_channel().

[Matt Jordan]

> On May 21, 2013, 12:41 a.m., Matt Jordan wrote:
> > /team/group/bridge_construction/channels/chan_vpb.cc, lines 2269-2277
> > <https://reviewboard.asterisk.org/r/2558/diff/1/?file=38352#file38352line2269>
> >
> >     I think there should still be an ast_verb here indicating whether or not it got an Asterisk bridge.
> >     
> >     The verbose message just prior to this informs the user that we're checking for bridges, and that there wasn't a native bridge. If we find a bridge, we should tell them.
> 
> rmudgett wrote:
>     This old channel driver is using those ast_verb(5,..) calls as ast_debug() calls.  This is the main monitor loop so these messages are going to spam if you have the verbosity level set to 5 or higher.
>     
>     I'm just going to also remove the silly ast_verb() message.

Works for me.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2558/#review8673
-----------------------------------------------------------


On May 21, 2013, 1:09 a.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2558/
> -----------------------------------------------------------
> 
> (Updated May 21, 2013, 1:09 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The new bridging API will never set the ast_channel_internal_bridged_channel().  This patch removes most calls to ast_channel_internal_bridged_channel().
> 
> 
> Diffs
> -----
> 
>   /team/group/bridge_construction/CHANGES 389336 
>   /team/group/bridge_construction/apps/app_dumpchan.c 389336 
>   /team/group/bridge_construction/channels/chan_unistim.c 389336 
>   /team/group/bridge_construction/channels/chan_vpb.cc 389336 
>   /team/group/bridge_construction/include/asterisk/channel.h 389336 
>   /team/group/bridge_construction/main/channel.c 389336 
>   /team/group/bridge_construction/main/cli.c 389336 
>   /team/group/bridge_construction/main/features.c 389336 
>   /team/group/bridge_construction/main/manager.c 389336 
> 
> Diff: https://reviewboard.asterisk.org/r/2558/diff/
> 
> 
> Testing
> -------
> 
> Checked output of DumpChan() output.
> Checked output of AMI Status action.
> Checked CLI "core show channels verbose" and "core show channel x".
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130521/83789fb5/attachment-0001.htm>