[asterisk-dev] [Code Review] 2549: Add dial (begin / end) events to app_queue and app_followme

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2549/#review8672
-----------------------------------------------------------



/trunk/apps/app_dial.c
<https://reviewboard.asterisk.org/r/2549/#comment17011>

    And thanks for catching this as well. I did a double take here until I realized you were CANCELing the original channel dial, not the forwarded channel.



/trunk/apps/app_dial.c
<https://reviewboard.asterisk.org/r/2549/#comment17010>

    Eek. Thanks for catching that.



/trunk/apps/app_followme.c
<https://reviewboard.asterisk.org/r/2549/#comment17012>

    Pedantic: put the dial publishing after the comment



/trunk/apps/app_followme.c
<https://reviewboard.asterisk.org/r/2549/#comment17013>

    And here



/trunk/apps/app_followme.c
<https://reviewboard.asterisk.org/r/2549/#comment17014>

    And lastly here



/trunk/apps/app_followme.c
<https://reviewboard.asterisk.org/r/2549/#comment17015>

    I think you'll publish a dial begin here even if ast_call fails, which probably isn't what you want. It also looks like destroy_calling_node will have done "things" to tmpuser.



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/2549/#comment17016>

    That looks like a lovely bit of lock unbalancing. I'm guessing this should be fixed in 1.8+



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/2549/#comment17017>

    EXITCONTEXT isn't something 'known' currently. I'm not against it, but it doesn't really map cleanly to a hangup cause code, and what the dial end message conveys is the final status of the relationship between the caller/callee during dialing, not why the caller attempted to bail.
    
    tl;dr:
    Why not just CANCEL?


- Matt Jordan


On May 17, 2013, 9:19 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2549/
> -----------------------------------------------------------
> 
> (Updated May 17, 2013, 9:19 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21550 and ASTERISK-21551
>     https://issues.asterisk.org/jira/browse/ASTERISK-21550
>     https://issues.asterisk.org/jira/browse/ASTERISK-21551
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Since they're silly, and don't use the dial API.
> 
> There is a change in app_dial that addresses an incorrect (backwards) begin event and a missing end event that I noticed.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_dial.c 388998 
>   /trunk/apps/app_followme.c 388998 
>   /trunk/apps/app_queue.c 388998 
>   /trunk/include/asterisk/dial.h 388998 
>   /trunk/main/dial.c 388998 
> 
> Diff: https://reviewboard.asterisk.org/r/2549/diff/
> 
> 
> Testing
> -------
> 
> For app_queue, I get the same number of begin events as I do end events.  I get the number I would expect in all cases I've tried (including the forwarding logic).
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130520/13b0e1bc/attachment-0001.htm>