[asterisk-dev] [Code Review] 2551: Make ConfBridge use its own unreal announcer channel driver and delete chan_bridge.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2551/#review8670
-----------------------------------------------------------



/team/group/bridge_construction/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/2551/#comment16988>

    Since ConfBridge is already split up into multiple files, both of these application specific channel drivers are good candidates for being put into their own files.



/team/group/bridge_construction/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/2551/#comment16990>

    That's not entirely true. It returns -1 on error; 0 on success



/team/group/bridge_construction/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/2551/#comment16991>

    You may want to consider using a scoped channel lock here, since you have multiple error return paths.


- Matt Jordan


On May 17, 2013, 11:39 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2551/
> -----------------------------------------------------------
> 
> (Updated May 17, 2013, 11:39 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21271
>     https://issues.asterisk.org/jira/browse/ASTERISK-21271
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This is a fairly stand alone change on the way to making ConfBridge a subclass of ast_bridge.
> 
> * Made the ConfBridge recorder channel driver type name and channel name consistent.  Before the channel driver type was ConfBridgeRec and the created channel name was ConfBridgeRecorder/conf-%s-uid-%d.  Now it is CBRec and CBRec/conf-%s-uid-%d respectively.
> 
> * Replaced ConfBridge usage of chan_bridge with its own announcer channel.
> 
> * Deleted chan_bridge since it was created just for ConfBridge and it no longer uses it.
> 
> * The CBRec and CBAnn drivers set the recorder and announcer bridge channel roles respectively and are marked as IMMOVABLE to bridge merges and channel moves.
> 
> 
> Diffs
> -----
> 
>   /team/group/bridge_construction/apps/app_confbridge.c 389037 
>   /team/group/bridge_construction/channels/chan_bridge.c 389037 
> 
> Diff: https://reviewboard.asterisk.org/r/2551/diff/
> 
> 
> Testing
> -------
> 
> ConfBridge still is able to announce participants and play messages to the bridge.
> ConfBridge still is able to record the conference.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130520/89a8f0e0/attachment-0001.htm>