[asterisk-dev] [Code Review] 2471: Basic res_sip XML documentation

[Brad Latus]

> On May 13, 2013, 2:21 p.m., opticron wrote:
> > trunk/res/res_sip.c, line 131
> > <https://reviewboard.asterisk.org/r/2471/diff/3/?file=37633#file37633line131>
> >
> >     This should mention reINVITEs.

added note for re-invite, but don't know enough to put a good description at this time.


> On May 13, 2013, 2:21 p.m., opticron wrote:
> > trunk/res/res_sip.c, line 304
> > <https://reviewboard.asterisk.org/r/2471/diff/3/?file=37633#file37633line304>
> >
> >     Change to "Lifetime of a nonce associated with this authorization section."

but what is this lifetime in.. seconds / minutes / etc ?


> On May 13, 2013, 2:21 p.m., opticron wrote:
> > trunk/res/res_sip.c, lines 322-330
> > <https://reviewboard.asterisk.org/r/2471/diff/3/?file=37633#file37633line322>
> >
> >     This is still here

removed.. we'll let the errors on startup happen for now.


> On May 13, 2013, 2:21 p.m., opticron wrote:
> > trunk/res/res_sip.c, line 461
> > <https://reviewboard.asterisk.org/r/2471/diff/3/?file=37633#file37633line461>
> >
> >     This line doesn't flow correctly.

open to removing altogether..


> On May 13, 2013, 2:21 p.m., opticron wrote:
> > trunk/res/res_sip_outbound_registration.c, lines 89-90
> > <https://reviewboard.asterisk.org/r/2471/diff/3/?file=37636#file37636line89>
> >
> >     If it isn't the configured transports, this needs to enumerate available options.

I think i'm wrong here..


- Brad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2471/#review8583
-----------------------------------------------------------


On May 13, 2013, 7:54 a.m., Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2471/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 7:54 a.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21668
>     https://issues.asterisk.org/jira/browse/ASTERISK-21668
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Start of XML documentation for res_sip, not complete but a start.
> 
> 
> Diffs
> -----
> 
>   trunk/res/res_sip.c 387348 
>   trunk/res/res_sip_acl.c 387348 
>   trunk/res/res_sip_endpoint_identifier_ip.c 387348 
>   trunk/res/res_sip_outbound_registration.c 387348 
> 
> Diff: https://reviewboard.asterisk.org/r/2471/diff/
> 
> 
> Testing
> -------
> 
> Ran xmllint - no errors.
> No warnings about missing XML during asterisk startup.
> 
> 
> Thanks,
> 
> Brad Latus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130519/41034f5c/attachment-0001.htm>