[asterisk-dev] [Code Review] 2543: Gulp blind and attended transfer support

[Joshua Colp]

> On May 16, 2013, 9:43 p.m., Mark Michelson wrote:
> > /team/group/bridge_construction/res/res_sip_refer.c, lines 298-299
> > <https://reviewboard.asterisk.org/r/2543/diff/2/?file=37946#file37946line298>
> >
> >     This use of "transferee" is non-standard and liable to cause confusion. This session is actually also the transferer, but it is bridged with the transfer target rather than the transferee.
> 
> Joshua Colp wrote:
>     Can you suggest an alternate?

Changed to transferer_second actually to be better reflect what it is.


> On May 16, 2013, 9:43 p.m., Mark Michelson wrote:
> > /team/group/bridge_construction/res/res_sip_refer.c, lines 250-253
> > <https://reviewboard.asterisk.org/r/2543/diff/2/?file=37946#file37946line250>
> >
> >     This return point causes a return value of NULL to be ambiguous.
> >     
> >     Callers of refer_progress_alloc() assume that a NULL return means that progress was not requested (i.e. no error), but it can also indicate that a failure occurred when attempting to allocate the progress structure (i.e. an error).
> 
> Joshua Colp wrote:
>     I erred on this on purpose to give a better chance for the requested action (transfer) to be completed successfully, despite the inability to allocate some memory and monitor its progress. I'm fine with changing this to fail if you think so.

Changed, actually.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2543/#review8636
-----------------------------------------------------------


On May 15, 2013, 6:32 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2543/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 6:32 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> These changes add support for the following:
> 
> 1. Blind transfers originating from a remote device
> 2. Blind transfers originated to a remote device
> 3. Redirection originated to a remote device (before session has been answered)
> 4. Attended transfers originating from a remote device when both legs are local
> 5. Attended transfers originating from a remote device when only one leg is local (additional dialplan logic required)
> 6. Replacement of a session using INVITE with replaces
> 7. Transfer progress notification using a frame hook
> 8. norefersub support
> 
> * This patch relies on pimp my SIP, bridge_construction, and more_transfer.
> 
> 
> Diffs
> -----
> 
>   /team/group/bridge_construction/res/res_sip_refer.c PRE-CREATION 
>   /team/group/bridge_construction/include/asterisk/res_sip_session.h 388524 
>   /team/group/bridge_construction/channels/chan_gulp.c 388524 
>   /team/group/bridge_construction/res/res_sip_session.c 388524 
>   /team/group/bridge_construction/res/res_sip_session.exports.in 388524 
> 
> Diff: https://reviewboard.asterisk.org/r/2543/diff/
> 
> 
> Testing
> -------
> 
> Testing the various scenarios using SIPP and phones.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130518/3d871853/attachment.htm>