[asterisk-dev] [Code Review] 2550: res_parking: Dynamic Parking Lots

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2550/
-----------------------------------------------------------

Review request for Asterisk Developers, Matt Jordan and rmudgett.


Bugs: ASTERISK-21644
    https://issues.asterisk.org/jira/browse/ASTERISK-21644


Repository: Asterisk


Description
-------

Dynamic Parking Lots. Parking lots that are made based on other parking lots as well as a combination of some variables. They get a little bit of overlap extension checking that they do before actually trying to register any extensions...

For the most part, they function like normal parking lots. The exception is that they get broken down if they ever become empty. In that sense, they behave as though they have already been disabled, it's just that you can keep parking to them while they are still alive.

Some of the stuff in this review references functionality that is going to be provided by the extensions registration update once that is finished.


Diffs
-----

  /team/group/bridge_construction/CHANGES 389006 
  /team/group/bridge_construction/res/parking/parking_applications.c 389006 
  /team/group/bridge_construction/res/parking/parking_bridge.c 389006 
  /team/group/bridge_construction/res/parking/parking_ui.c 389006 
  /team/group/bridge_construction/res/parking/res_parking.h 389006 
  /team/group/bridge_construction/res/res_parking.c 389006 

Diff: https://reviewboard.asterisk.org/r/2550/diff/


Testing
-------

Created dynamic parking lots with a number of different variables, made sure I could keep parking additional people to them as long as they didn't break down, made sure they were destroyed when they became empty, made sure they didn't leak memory in any obvious ways (tracked by res_parking.c, parking_bridge.c, and parking_controller.c) made sure they were visible in the UI as long as they were alive.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130517/53496f04/attachment.htm>