[asterisk-dev] [Code Review] 2512: Move origination to dialing API

Matt Jordan reviewboard at asterisk.org
Fri May 17 13:29:07 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2512/#review8651
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On May 9, 2013, 7:02 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2512/
> -----------------------------------------------------------
> 
> (Updated May 9, 2013, 7:02 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change adds a few minor features to the dialing API and moves origination to using it. As a result code duplication is reduced and readability has increased.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/dial.h 388214 
>   /trunk/main/dial.c 388214 
>   /trunk/main/manager_channels.c 388214 
>   /trunk/main/pbx.c 388214 
> 
> Diff: https://reviewboard.asterisk.org/r/2512/diff/
> 
> 
> Testing
> -------
> 
> Tested various origination scenarios and confirmed they all work as expected.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130517/ad218013/attachment-0001.htm>


More information about the asterisk-dev mailing list