[asterisk-dev] backport RAII_VAR to 1.8?

[Matthew Jordan]

On 05/17/2013 12:54 PM, Russell Bryant wrote:
> On Fri, May 17, 2013 at 1:35 PM, Paul Belanger

<snip>

> The size of this backport is tiny.  It's a small macro.  It's just
> incredibly useful and actually helps write code less likely to contain
> errors.
> 
> If it's a problem, it shouldn't be *too* hard to pull it back out.  The
> difficultly comes with however many places you have started using it.
>  In my case, it's in the SLA code, so it's a pretty small fraction of
> the code base.  If it gets backported, explodes through the 1.8 code,
> and then a problem is found 6 months later, that would be much more
> painful.  I wouldn't expect it to spread too fast in 1.8, since the
> changes are intentionally minimal.  It just might make fixing some bugs
> easier.
> 
> Compiler version impact is worth considering.  I don't know what the
> specific impact is in terms of distro support, though.  How about we
> assume it's ok, and if there's an uproar, I agree to do the work to
> revert the usage I added.
> 

Ohs noz. You're ref counting SLA.

USE RAII_VAR.

-- 
Matthew Jordan
Digium, Inc. | Engineering Manager
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: http://digium.com & http://asterisk.org