[asterisk-dev] [Code Review] 2531: Implement REST API for playback to chamnel

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2531/#review8633
-----------------------------------------------------------



/team/dlee/res-stasis-cleanup/res/res_stasis_playback.c
<https://reviewboard.asterisk.org/r/2531/#comment16851>

    This seems like it should be off in a function.



/team/dlee/res-stasis-cleanup/res/res_stasis_playback.c
<https://reviewboard.asterisk.org/r/2531/#comment16852>

    This needs a destructor to free the string fields. Also, the media URI is not embedded in the struct.



/team/dlee/res-stasis-cleanup/res/res_stasis_playback.c
<https://reviewboard.asterisk.org/r/2531/#comment16853>

    Function available but not implemented.



/team/dlee/res-stasis-cleanup/res/stasis_http/resource_channels.c
<https://reviewboard.asterisk.org/r/2531/#comment16854>

    Debugging statement?



/team/dlee/res-stasis-cleanup/res/stasis_http/resource_channels.c
<https://reviewboard.asterisk.org/r/2531/#comment16855>

    Another debugging statement.


- opticron


On May 15, 2013, 5:04 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2531/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 5:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21283 and ASTERISK-21586
>     https://issues.asterisk.org/jira/browse/ASTERISK-21283
>     https://issues.asterisk.org/jira/browse/ASTERISK-21586
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> (depends on https://reviewboard.asterisk.org/r/2530)
> 
> This patch implements the REST API's for POST /channels/{channelId}/play
> and GET /playback/{playbackId}.
> 
> This allows an external application to initiate playback of a sound on a
> channel while the channel is in the Stasis application.
> 
> /play commands are issued asynchronously, and return immediately with
> the URL of the associated /playback resource. Playback commands queue up,
> playing in succession. The /playback resource shows the state of a
> playback operation as enqueued, playing or complete. (Although the
> operation will only be in the 'complete' state for a very short time,
> since it is almost immediately freed up).
> 
> (closes issue ASTERISK-21283)
> (closes issue ASTERISK-21586)
> Review: https://reviewboard.asterisk.org/r/2531/
> 
> 
> Diffs
> -----
> 
>   /team/dlee/res-stasis-cleanup/include/asterisk/app.h 388919 
>   /team/dlee/res-stasis-cleanup/include/asterisk/stasis_app_playback.h PRE-CREATION 
>   /team/dlee/res-stasis-cleanup/include/asterisk/stasis_channels.h 388919 
>   /team/dlee/res-stasis-cleanup/include/asterisk/stasis_http.h 388919 
>   /team/dlee/res-stasis-cleanup/main/channel.c 388919 
>   /team/dlee/res-stasis-cleanup/main/channel_internal_api.c 388919 
>   /team/dlee/res-stasis-cleanup/main/stasis_channels.c 388919 
>   /team/dlee/res-stasis-cleanup/res/res_stasis_http.c 388919 
>   /team/dlee/res-stasis-cleanup/res/res_stasis_http_channels.c 388919 
>   /team/dlee/res-stasis-cleanup/res/res_stasis_json_events.c 388919 
>   /team/dlee/res-stasis-cleanup/res/res_stasis_json_events.exports.in 388919 
>   /team/dlee/res-stasis-cleanup/res/res_stasis_playback.c PRE-CREATION 
>   /team/dlee/res-stasis-cleanup/res/res_stasis_playback.exports.in PRE-CREATION 
>   /team/dlee/res-stasis-cleanup/res/stasis/control.c 388919 
>   /team/dlee/res-stasis-cleanup/res/stasis_http/resource_channels.h 388919 
>   /team/dlee/res-stasis-cleanup/res/stasis_http/resource_channels.c 388919 
>   /team/dlee/res-stasis-cleanup/res/stasis_http/resource_playback.c 388919 
>   /team/dlee/res-stasis-cleanup/res/stasis_json/resource_channels.h 388919 
>   /team/dlee/res-stasis-cleanup/res/stasis_json/resource_events.h 388919 
>   /team/dlee/res-stasis-cleanup/rest-api/api-docs/channels.json 388919 
>   /team/dlee/res-stasis-cleanup/rest-api/api-docs/events.json 388919 
> 
> Diff: https://reviewboard.asterisk.org/r/2531/diff/
> 
> 
> Testing
> -------
> 
> Poked the playback API manually.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130516/5f7647e6/attachment-0001.htm>