[asterisk-dev] [Code Review] 2548: Publish the outbound channel's application/data when dialing

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2548/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

This patch does two things:

* It fixes a bug where the outbound channel's application/data set by the dialing API/app_dial is not communicated until the channel hangs up. If that happens, AMI would incorrectly send a NewExten event immediately after a Hangup. This isn't really AMIs fault, as the dialing APIs never communicated that they changed data on the channel.

* It makes public sending a stasis message about a change in channel state.


Diffs
-----

  /trunk/apps/app_dial.c 388920 
  /trunk/include/asterisk/stasis_channels.h 388920 
  /trunk/main/channel.c 388920 
  /trunk/main/dial.c 388920 
  /trunk/main/stasis_channels.c 388920 

Diff: https://reviewboard.asterisk.org/r/2548/diff/


Testing
-------

The bug was found by using an optimizing Local channel to Dial another channel (say, a SIP one). With this patch, the problem no longer occurs.


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130515/08853f26/attachment.htm>