[asterisk-dev] [Code Review] 2546: res_parking: Default Parking Lot

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2546/
-----------------------------------------------------------

Review request for Asterisk Developers, Matt Jordan and rmudgett.


Bugs: ASTERISK-21643
    https://issues.asterisk.org/jira/browse/ASTERISK-21643


Repository: Asterisk


Description
-------

Default Parking Lot. Pretty self explanatory. It's a parking lot.  It's named default.  It uses default options.

Actually, there is one difference between this parking lot and what you would get if you just stuck
[default]

in the config file, and that's that if the default parking lot isn't specified in this way, it will set parkext to 700 so that dialplan generation
will be used and an actual usable parking lot similar to the ones that used to be generated by features.conf will be set up.


Diffs
-----

  /team/jrose/bridge_projects/res/res_parking.c 388603 

Diff: https://reviewboard.asterisk.org/r/2546/diff/


Testing
-------

Tested with and without the presence of [default] in res_parking.conf
Tested reloads removing and adding [default]
Checked memory consumption before and after reloads for both adding and removing default.
Checked options in the default parking lot created without the presence of [default]
Checked options in the default parking lot created with the presence of [default]


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130515/df2e8871/attachment.htm>