[asterisk-dev] [Code Review] 2531: Implement REST API for playback to chamnel

[David Lee]

> On May 13, 2013, 10:03 p.m., Matt Jordan wrote:
> > /team/dlee/res-stasis-cleanup/include/asterisk/stasis_channels.h, lines 128-138
> > <https://reviewboard.asterisk.org/r/2531/diff/1/?file=37617#file37617line128>
> >
> >     I'm probably going to lose this merge race, but I have a version of this same function with a slightly different name in the "Refactor random AMI events" review.
> >     
> >     (Yay find and replace)

Which branch? I can change mine to match so at least the merge will be simpler.


> On May 13, 2013, 10:03 p.m., Matt Jordan wrote:
> > /team/dlee/res-stasis-cleanup/res/res_stasis_http_events.c, lines 91-97
> > <https://reviewboard.asterisk.org/r/2531/diff/1/?file=37624#file37624line91>
> >
> >     I had comments here, then I realized this was auto-generated.
> >     
> >     Do we need an issue opened up for validation of passed in parameters?
> >     
> >     If we aren't going to validate a parameter (as in this case, where validation doesn't need to happen as no parameters really drive the response result), can we remove the 'validation' portion from the template?

I discussed that with opticron. We feel that adding validation is one of those things that can happen as needed.

While we could do remove unnecessary validation stuff from the template, in general I believe that it would be better to let the compiler optimize away useless code than putting a lot of complexity in the generator.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2531/#review8592
-----------------------------------------------------------


On May 10, 2013, 1:52 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2531/
> -----------------------------------------------------------
> 
> (Updated May 10, 2013, 1:52 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21283 and ASTERISK-21586
>     https://issues.asterisk.org/jira/browse/ASTERISK-21283
>     https://issues.asterisk.org/jira/browse/ASTERISK-21586
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> (depends on https://reviewboard.asterisk.org/r/2530)
> 
> This patch implements the REST API's for POST /channels/{channelId}/play
> and GET /playback/{playbackId}.
> 
> This allows an external application to initiate playback of a sound on a
> channel while the channel is in the Stasis application.
> 
> /play commands are issued asynchronously, and return immediately with
> the URL of the associated /playback resource. Playback commands queue up,
> playing in succession. The /playback resource shows the state of a
> playback operation as enqueued, playing or complete. (Although the
> operation will only be in the 'complete' state for a very short time,
> since it is almost immediately freed up).
> 
> (closes issue ASTERISK-21283)
> (closes issue ASTERISK-21586)
> Review: https://reviewboard.asterisk.org/r/2531/
> 
> 
> Diffs
> -----
> 
>   /team/dlee/res-stasis-cleanup/include/asterisk/stasis_app_playback.h PRE-CREATION 
>   /team/dlee/res-stasis-cleanup/include/asterisk/stasis_channels.h 388370 
>   /team/dlee/res-stasis-cleanup/include/asterisk/stasis_http.h 388370 
>   /team/dlee/res-stasis-cleanup/main/channel.c 388370 
>   /team/dlee/res-stasis-cleanup/main/channel_internal_api.c 388370 
>   /team/dlee/res-stasis-cleanup/main/stasis_channels.c 388370 
>   /team/dlee/res-stasis-cleanup/res/res_stasis_http.c 388370 
>   /team/dlee/res-stasis-cleanup/res/res_stasis_http_channels.c 388370 
>   /team/dlee/res-stasis-cleanup/res/res_stasis_http_events.c 388370 
>   /team/dlee/res-stasis-cleanup/res/res_stasis_playback.c PRE-CREATION 
>   /team/dlee/res-stasis-cleanup/res/res_stasis_playback.exports.in PRE-CREATION 
>   /team/dlee/res-stasis-cleanup/res/stasis_http/resource_channels.h 388370 
>   /team/dlee/res-stasis-cleanup/res/stasis_http/resource_channels.c 388370 
>   /team/dlee/res-stasis-cleanup/res/stasis_http/resource_events.h 388370 
>   /team/dlee/res-stasis-cleanup/res/stasis_http/resource_playback.c 388370 
>   /team/dlee/res-stasis-cleanup/rest-api/api-docs/channels.json 388370 
>   /team/dlee/res-stasis-cleanup/rest-api/api-docs/events.json 388370 
> 
> Diff: https://reviewboard.asterisk.org/r/2531/diff/
> 
> 
> Testing
> -------
> 
> Poked the playback API manually.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130515/9c76b923/attachment.htm>