[asterisk-dev] [Code Review] 2541: Pimp my SIP: One Touch Recording support

[Mark Michelson]

> On May 15, 2013, 6:46 p.m., Mark Michelson wrote:
> > /team/group/pimp_my_sip/res/res_sip_one_touch_record_info.c, line 43
> > <https://reviewboard.asterisk.org/r/2541/diff/1/?file=37943#file37943line43>
> >
> >     Use ast_sip_session_send_response() instead. This way, session supplements' outbound_response callbacks will be called.
> 
> Joshua Colp wrote:
>     Can you actually call ast_sip_session_send_response on this? IE: Will pjsip_inv_send_msg work?
> 
> Joshua Colp wrote:
>     Looking at the code for it indicates, no. You can not do that.

Hm, that means we should probably adjust ast_sip_session_send_response() to be able to be used in this sort of situation then. But don't let that hold up this review. Ship as-is!


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2541/#review8619
-----------------------------------------------------------


On May 15, 2013, 6:38 p.m., Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2541/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 6:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21501
>     https://issues.asterisk.org/jira/browse/ASTERISK-21501
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds One Touch Recording functionality, as implemented by snom phones (and perhaps others), to the new SIP driver.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/include/asterisk/res_sip.h 388882 
>   /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 388882 
>   /team/group/pimp_my_sip/res/res_sip_one_touch_record_info.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2541/diff/
> 
> 
> Testing
> -------
> 
> Ran through the new tests in the testsuite (see review #2542).  I don't have a snom so I wasn't able to test it directly.
> 
> 
> Thanks,
> 
> Sean Bright
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130515/e3be4827/attachment.htm>