[asterisk-dev] [Code Review] 2537: Parking: Park and Announce Application

[rmudgett]

> On May 14, 2013, 8:40 p.m., rmudgett wrote:
> > /team/jrose/bridge_projects/res/parking/parking_applications.c, lines 651-655
> > <https://reviewboard.asterisk.org/r/2537/diff/1/?file=37847#file37847line651>
> >
> >     The callerid used for this call needs to be the callerid of the parked call.
> 
> jrose wrote:
>     Added it. Honestly I'm not sure why we want that caller ID info here considering that this isn't the person making the call, but I suppose for the sake of keeping things as they are this makes sense.

If the announce channel was your SIP phone, you would see who was parked on the display and then hear where they were parked.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2537/#review8601
-----------------------------------------------------------


On May 14, 2013, 5:53 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2537/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 5:53 p.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Bugs: ASTERISK-21352
>     https://issues.asterisk.org/jira/browse/ASTERISK-21352
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Recreate the ParkAndAnnounce application using the new parking system
> 
> 
> Diffs
> -----
> 
>   /team/jrose/bridge_projects/CHANGES 388603 
>   /team/jrose/bridge_projects/UPGRADE.txt 388603 
>   /team/jrose/bridge_projects/apps/app_parkandannounce.c 388603 
>   /team/jrose/bridge_projects/res/parking/parking_applications.c 388603 
>   /team/jrose/bridge_projects/res/parking/res_parking.h 388603 
>   /team/jrose/bridge_projects/res/res_parking.c 388603 
> 
> Diff: https://reviewboard.asterisk.org/r/2537/diff/
> 
> 
> Testing
> -------
> 
> called the following extension with SIP/Gold
> 
> exten => 9600,1,ParkAndAnnounce(testlot1,,tt-weasels:PARKED,SIP/123)
> 
> Made sure parking worked normally and that no memory was leaked from parking/parking_applications.c and that no channels were leaked.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130515/7ead7cf5/attachment.htm>