[asterisk-dev] [Code Review] 2510: Stasis: Update confbridge events.

[jrose]

> On May 15, 2013, 2:25 p.m., Matt Jordan wrote:
> > /team/group/bridge_construction/apps/confbridge/confbridge_manager.c, lines 112-113
> > <https://reviewboard.asterisk.org/r/2510/diff/2/?file=37821#file37821line112>
> >
> >     I think you copy/pasted this a few too many times. Why does the ConfbridgeRecord event need a reference to the ConfbridgeEnd event?
> >     
> >     Events should have references to:
> >     * In an event pair (begin/end), a reference to their corresponding pair event
> >     * Actions that cause the events to occur
> >     * Applications that cause the events to occur

Fixing all of these...

ConfbridgeStart : ConfbridgeEnd
ConfbridgeJoin  : ConfbridgeLeave
ConfbridgeRecord : ConfbridgeStopRecord
ConfbridgeMute : ConfbridgeUnmute
ConfbridgeTalking

Also noticed some other problems with documentation (accidentally ConfbridgeStopRecording named as a second ConfbridgeLeave for instance). These are all fixed now as well.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2510/#review8611
-----------------------------------------------------------


On May 13, 2013, 5:07 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2510/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 5:07 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee, kmoore, and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21468
>     https://issues.asterisk.org/jira/browse/ASTERISK-21468
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Not a whole ton to say about this one.  More manager event stuff being turned into stasis stuff. This does push out some bridge blob messages over the channel topic, which I suppose might be slightly interesting.
> 
> 
> Diffs
> -----
> 
>   /team/group/bridge_construction/apps/app_confbridge.c 388524 
>   /team/group/bridge_construction/apps/confbridge/confbridge_manager.c PRE-CREATION 
>   /team/group/bridge_construction/apps/confbridge/include/confbridge.h 388524 
> 
> Diff: https://reviewboard.asterisk.org/r/2510/diff/
> 
> 
> Testing
> -------
> 
> Made sure each event would be issued to manager through with all the appropriate bridge/channels snapshot information and expected fields.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130515/d125c25a/attachment.htm>