[asterisk-dev] [Code Review] 2536: Moving chan_mgcp to attended transfer API

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2536/#review8610
-----------------------------------------------------------

Ship it!


Only thing left is a minor removal.


/team/mmichelson/more_transfer/channels/chan_mgcp.c
<https://reviewboard.asterisk.org/r/2536/#comment16804>

    If this is only going to return 0 or 1, then the code that calls attempt_transfer() should remove its check for a negative return.


- Mark Michelson


On May 14, 2013, 11:13 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2536/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 11:13 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change cleans up the MGCP transfer code a bit, moves it to the new attended transfer API, and adds a few comments.
> 
> 
> Diffs
> -----
> 
>   /team/mmichelson/more_transfer/channels/chan_mgcp.c 388524 
> 
> Diff: https://reviewboard.asterisk.org/r/2536/diff/
> 
> 
> Testing
> -------
> 
> I wish.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130515/f7120d78/attachment-0001.htm>