[asterisk-dev] [Code Review] 2539: Fix up VM snapshot, INBOX combining.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2539/#review8606
-----------------------------------------------------------

Ship it!


Huzzah for passing unit tests

- Matt Jordan


On May 14, 2013, 8:58 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2539/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 8:58 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> VM snapshots have a "combine" mode, that allows multiple folders to be merged into INBOX.
> 
> This should make it a little more clear about what's going on.  It was overly complicated, and handled unnecessary/invalid use cases, like requesting the Old folder while trying to combine (I assert that to the POV of the snapshot requester, Old does not exist, when combine is enabled).
> 
> 
> Diffs
> -----
> 
>   /branches/11/apps/app_voicemail.c 388696 
> 
> Diff: https://reviewboard.asterisk.org/r/2539/diff/
> 
> 
> Testing
> -------
> 
> The bug that this was written to address is fixed - Old messages no longer show up in other folders.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130514/40e7a481/attachment.htm>