[asterisk-dev] [Code Review] 2534: Move JSON event generators into separate modules

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2534/#review8588
-----------------------------------------------------------

Ship it!


Fix this minor issue with the AST_MODULE_INFO, and it's all good.


trunk/rest-api-templates/res_stasis_json_resource.c.mustache
<https://reviewboard.asterisk.org/r/2534/#comment16752>

    If you're going to specify AST_MODFLAG_LOAD_ORDER, you should also specify .load_pri.


- David Lee


On May 13, 2013, 11:53 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2534/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 11:53 a.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This moves the JSON event generators out of the Stasis-HTTP modules and into standalone JSON-related counterparts so that Stasis-HTTP and res_stasis can depend on them without creating dependency cycles.  This also provides a future location for Swagger Model validator functions once the generators for that code are written.
> 
> 
> Diffs
> -----
> 
>   trunk/res/stasis_json/resource_asterisk.h PRE-CREATION 
>   trunk/res/stasis_http/resource_sounds.h 388522 
>   trunk/res/stasis_http/resource_recordings.h 388522 
>   trunk/res/stasis_http/resource_playback.h 388522 
>   trunk/res/stasis_http/resource_events.h 388522 
>   trunk/res/stasis_http/resource_endpoints.h 388522 
>   trunk/res/stasis_http/resource_channels.h 388522 
>   trunk/res/stasis_http/resource_bridges.h 388522 
>   trunk/res/stasis_http/resource_asterisk.h 388522 
>   trunk/res/res_stasis_json_sounds.exports.in PRE-CREATION 
>   trunk/res/res_stasis_json_sounds.c PRE-CREATION 
>   trunk/res/res_stasis_json_recordings.exports.in PRE-CREATION 
>   trunk/res/res_stasis_json_recordings.c PRE-CREATION 
>   trunk/res/res_stasis_json_playback.exports.in PRE-CREATION 
>   trunk/res/res_stasis_json_playback.c PRE-CREATION 
>   trunk/res/res_stasis_json_events.exports.in PRE-CREATION 
>   trunk/res/res_stasis_json_events.c PRE-CREATION 
>   trunk/res/res_stasis_json_endpoints.exports.in PRE-CREATION 
>   trunk/res/res_stasis_json_endpoints.c PRE-CREATION 
>   trunk/res/res_stasis_json_channels.exports.in PRE-CREATION 
>   trunk/res/res_stasis_json_channels.c PRE-CREATION 
>   trunk/res/res_stasis_json_bridges.exports.in PRE-CREATION 
>   trunk/res/res_stasis_json_bridges.c PRE-CREATION 
>   trunk/res/res_stasis_json_asterisk.exports.in PRE-CREATION 
>   trunk/res/res_stasis_json_asterisk.c PRE-CREATION 
>   trunk/res/res_stasis_http_events.c 388522 
>   trunk/res/res_stasis.c 388522 
>   trunk/res/stasis_json/resource_bridges.h PRE-CREATION 
>   trunk/res/stasis_json/resource_channels.h PRE-CREATION 
>   trunk/res/stasis_json/resource_endpoints.h PRE-CREATION 
>   trunk/res/stasis_json/resource_events.h PRE-CREATION 
>   trunk/res/stasis_json/resource_playback.h PRE-CREATION 
>   trunk/res/stasis_json/resource_recordings.h PRE-CREATION 
>   trunk/res/stasis_json/resource_sounds.h PRE-CREATION 
>   trunk/rest-api-templates/make_stasis_http_stubs.py 388522 
>   trunk/rest-api-templates/res_stasis_http_resource.c.mustache 388522 
>   trunk/rest-api-templates/res_stasis_json_resource.c.mustache PRE-CREATION 
>   trunk/rest-api-templates/res_stasis_json_resource.exports.mustache PRE-CREATION 
>   trunk/rest-api-templates/stasis_http_resource.h.mustache 388522 
>   trunk/rest-api-templates/stasis_json_resource.h.mustache PRE-CREATION 
>   trunk/tests/test_res_stasis.c 388522 
> 
> Diff: https://reviewboard.asterisk.org/r/2534/diff/
> 
> 
> Testing
> -------
> 
> Ran app_replaced test from test_res_stasis which was the test that was causing a segfault on failed symbol lookup.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130513/c58d2004/attachment.htm>