[asterisk-dev] [Code Review] 2496: Stasis: Update security events to use stasis. Move ACL messages to the security topic.

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2496/
-----------------------------------------------------------

(Updated May 13, 2013, 4:32 p.m.)


Review request for Asterisk Developers, David Lee, kmoore, and Matt Jordan.


Changes
-------

Address Kinsey's review. Part of that involved going through and unifying how we specify transport types. Now netsock2.h specifies an ast_transport enumerator which has a bit for each transport type (since chan_sip in particular required this because it could specify multiple transports in a single variable. Others used to use a more simple sequential enumeration).


Bugs: ASTERISK-21103
    https://issues.asterisk.org/jira/browse/ASTERISK-21103


Repository: Asterisk


Description
-------

Stage 3/3 of ASTERISK-21103. In order to convert this set of messages I had to change all of the event blob stuff into JSON strings inside of a JSON blob loaded onto a JSON payload and sent out over stasis to the security topic where it is then consumed by stasis and read into a log message in the appropriate fashion with the fields in the right order to catch the bird to catch the spider to catch the fly.


Diffs (updated)
-----

  /trunk/CHANGES 388522 
  /trunk/channels/chan_iax2.c 388522 
  /trunk/channels/chan_sip.c 388522 
  /trunk/channels/sip/config_parser.c 388522 
  /trunk/channels/sip/dialplan_functions.c 388522 
  /trunk/channels/sip/include/config_parser.h 388522 
  /trunk/channels/sip/include/sip.h 388522 
  /trunk/channels/sip/security_events.c 388522 
  /trunk/include/asterisk/acl.h 388522 
  /trunk/include/asterisk/json.h 388522 
  /trunk/include/asterisk/netsock2.h 388522 
  /trunk/include/asterisk/res_sip.h 388522 
  /trunk/include/asterisk/security_events.h 388522 
  /trunk/include/asterisk/security_events_defs.h 388522 
  /trunk/main/asterisk.c 388522 
  /trunk/main/json.c 388522 
  /trunk/main/manager.c 388522 
  /trunk/main/named_acl.c 388522 
  /trunk/main/security_events.c 388522 
  /trunk/res/res_security_log.c 388522 
  /trunk/res/res_sip.c 388522 
  /trunk/res/res_sip/config_transport.c 388522 
  /trunk/res/res_sip_nat.c 388522 
  /trunk/res/res_sip_outbound_registration.c 388522 
  /trunk/tests/test_security_events.c 388522 

Diff: https://reviewboard.asterisk.org/r/2496/diff/


Testing
-------

Made sure that the security messages were being generated in the same way as they were prior to the stasis change by using the following CLI command:

securityevents test generation


Examples Before:
[May  3 14:40:28] SECURITY[1305]: res_security_log.c:134 security_event_cb: SecurityEvent="FailedACL",EventTV="1367610028-869814",Severity="Error",Service="TEST",EventVersion="1",AccountID="Username",SessionID="Session123",LocalAddress="IPV4/UDP/192.168.1.1/12121",RemoteAddress="IPV4/UDP/192.168.1.2/12345",Module="test_security_events",ACLName="TEST_ACL",SessionTV="1367610028-869754"
[May  3 14:40:28] SECURITY[1305]: res_security_log.c:134 security_event_cb: SecurityEvent="InvalidAccountID",EventTV="1367610028-869895",Severity="Error",Service="TEST",EventVersion="1",AccountID="FakeUser",SessionID="Session456",LocalAddress="IPV4/TCP/10.1.2.3/4321",RemoteAddress="IPV4/TCP/10.1.2.4/123",Module="test_security_events",SessionTV="1367610028-869854"
[May  3 14:40:28] SECURITY[1305]: res_security_log.c:134 security_event_cb: SecurityEvent="SessionLimit",EventTV="1367610028-869960",Severity="Error",Service="TEST",EventVersion="1",AccountID="Jenny",SessionID="8675309",LocalAddress="IPV4/TLS/10.5.4.3/4444",RemoteAddress="IPV4/TLS/10.5.4.2/3333",Module="test_security_events",SessionTV="1367610028-869923"


Examples After:
[May  3 14:33:35] SECURITY[31607]: res_security_log.c:122 security_event_stasis_cb: SecurityEvent="FailedACL",EventTV="1367609615-957822",Severity="Error",Service="TEST",EventVersion="1",AccountID="Username",SessionID="Session123",LocalAddress="IPV4/UDP/192.168.1.1/12121",RemoteAddress="IPV4/UDP/192.168.1.2/12345",Module="test_security_events",ACLName="TEST_ACL",SessionTV="1367609615-957750"
[May  3 14:33:35] SECURITY[31608]: res_security_log.c:122 security_event_stasis_cb: SecurityEvent="InvalidAccountID",EventTV="1367609615-958101",Severity="Error",Service="TEST",EventVersion="1",AccountID="FakeUser",SessionID="Session456",LocalAddress="IPV4/TCP/10.1.2.3/4321",RemoteAddress="IPV4/TCP/10.1.2.4/123",Module="test_security_events",SessionTV="1367609615-957969"
[May  3 14:33:35] SECURITY[31608]: res_security_log.c:122 security_event_stasis_cb: SecurityEvent="SessionLimit",EventTV="1367609615-958404",Severity="Error",Service="TEST",EventVersion="1",AccountID="Jenny",SessionID="8675309",LocalAddress="IPV4/TLS/10.5.4.3/4444",RemoteAddress="IPV4/TLS/10.5.4.2/3333",Module="test_security_events",SessionTV="1367609615-958360"


As you can see it's basically identical aside from things that are expected to change between runs and the name of the function generating the messages.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130513/f73b89b8/attachment-0001.htm>