[asterisk-dev] [Code Review] 2501: Change IAX2 "inkeys" To Use A Dynamic String Buffer

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2501/#review8581
-----------------------------------------------------------



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2501/#comment16653>

    You need to save a copy of the value returned from ast_strdup, because the same value must be handed back to ast_free.  The strsep(3) function alters the value of the pointer.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2501/#comment16654>

    Same thing here.


- Tilghman Lesher


On May 10, 2013, 3:18 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2501/
> -----------------------------------------------------------
> 
> (Updated May 10, 2013, 3:18 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21398
>     https://issues.asterisk.org/jira/browse/ASTERISK-21398
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently, the setting of "inkeys" is limited to 256 chars .  If the user has many keys and the names of those key files are long, the 256 chars is not enough.
> 
> This changes the "inkeys" to be a dynamic size.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_iax2.c 388248 
> 
> Diff: https://reviewboard.asterisk.org/r/2501/diff/
> 
> 
> Testing
> -------
> 
> The reporter tested this on his machine where he was having a problem.  This fixed his issue.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130513/4d9783b8/attachment.htm>