[asterisk-dev] [Code Review] 2527: Complete Pimp My SIP Inband DTMF Support

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2527/#review8578
-----------------------------------------------------------

Ship it!



/team/group/pimp_my_sip/channels/chan_gulp.c
<https://reviewboard.asterisk.org/r/2527/#comment16651>

    This should be a higher debug level.


- Mark Michelson


On May 10, 2013, 1:07 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2527/
> -----------------------------------------------------------
> 
> (Updated May 10, 2013, 1:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Pimp My SIP will presently only generate inband DTMF, it has nothing to detect inbound DTMF. This change adds that functionality.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/channels/chan_gulp.c 388273 
>   /team/group/pimp_my_sip/include/asterisk/res_sip_session.h 388273 
>   /team/group/pimp_my_sip/res/res_sip_sdp_rtp.c 388273 
>   /team/group/pimp_my_sip/res/res_sip_session.c 388273 
> 
> Diff: https://reviewboard.asterisk.org/r/2527/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130510/70f376c2/attachment.htm>