[asterisk-dev] [Code Review] 2464: chan_gulp tests: Tests authentication failures for off nominal incoming call paths

svnbot reviewboard at asterisk.org
Thu May 9 15:40:47 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2464/
-----------------------------------------------------------

(Updated May 9, 2013, 3:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Committed in revision 3771


Repository: testsuite


Description
-------

This test sends various calls to res_sip for which authentication is expected to fail. This covers test #2 of the off-nominal paths listed on the test plan page of the wiki. It sends the wrong username, password, and *realm using IPv4/IPv6 and UDP/TCP. 

A small change was made to sipp.py to allow injection files to reside and be found in the sipp sub directory of the test directory.

* The realm is simply changed and the response digest is not recalculated in the Authorization header due to SIPp limitations.


Diffs
-----

  /asterisk/team/group/pimp_my_sip/lib/python/asterisk/sipp.py 3770 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/res_sip.conf PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/credentials-wrong_pass.csv PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/credentials-wrong_realm.csv PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/credentials-wrong_user.csv PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/playback_with_initial_sdp.xml PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/test-config.yaml PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/tests.yaml PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/configs/ast1/res_sip.conf PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/credentials-wrong_pass.csv PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/credentials-wrong_realm.csv PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/credentials-wrong_user.csv PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/playback_with_initial_sdp.xml PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/test-config.yaml PRE-CREATION 
  /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/tests.yaml 3770 

Diff: https://reviewboard.asterisk.org/r/2464/diff/


Testing
-------

* Ensured that all 24 combinations fail as expected.


Thanks,

jbigelow

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130509/9f3993e3/attachment.htm>


More information about the asterisk-dev mailing list