[asterisk-dev] [Code Review] 2512: Move origination to dialing API

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2512/#review8531
-----------------------------------------------------------



/trunk/include/asterisk/dial.h
<https://reviewboard.asterisk.org/r/2512/#comment16508>

    This has the same name as a struct above. Richard will be angry.



/trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/2512/#comment16506>

    These should be string fields.



/trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/2512/#comment16509>

    ast_dial_channel can return NULL.



/trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/2512/#comment16510>

    You may want to pull allocation and initialization of the pbx_outgoing struct into a separate allocation function to clean this up a bit.



/trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/2512/#comment16511>

    This should probably be moved below the thread creation.



/trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/2512/#comment16512>

    To avoid this.


- opticron


On May 8, 2013, 1:52 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2512/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 1:52 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change adds a few minor features to the dialing API and moves origination to using it. As a result code duplication is reduced and readability has increased.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/dial.h 388010 
>   /trunk/main/dial.c 388010 
>   /trunk/main/manager_channels.c 388010 
>   /trunk/main/pbx.c 388010 
> 
> Diff: https://reviewboard.asterisk.org/r/2512/diff/
> 
> 
> Testing
> -------
> 
> Tested various origination scenarios and confirmed they all work as expected.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130509/4af947e3/attachment-0001.htm>