[asterisk-dev] [Code Review] 2525: Test suite: Allow pluggable modules to be executed against particular Asterisk Versions

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2525/#review8529
-----------------------------------------------------------


We'll need a sample YAML file that documents the minversion/maxversion parameters


/asterisk/trunk/lib/python/asterisk/TestRunner.py
<https://reviewboard.asterisk.org/r/2525/#comment16504>

    Move all of this into a function that returns whether or not the module can run.
    
    I'd remove the debug statements here as well: they don't really add much value, and the YAML file already tells us what the min/max version is.
    
    The only thing that needs to be logged as a DEBUG statement is when we choose not to load the module as a result of the version check failing.



/asterisk/trunk/lib/python/asterisk/TestRunner.py
<https://reviewboard.asterisk.org/r/2525/#comment16505>

    I'd use the same nomenclature as the previous error statements, i.e., "TestRunner requires the Asterisk version to execute"


- Matt Jordan


On May 9, 2013, 5:29 a.m., jbigelow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2525/
> -----------------------------------------------------------
> 
> (Updated May 9, 2013, 5:29 a.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This allows pluggable modules to have their configuration section execute against particular version(s) of Asterisk. If the version of Asterisk meets the minversion and maxversion specified for the pluggable module, then it's config-section will be used. If neither minversion or maxversion are specified, it's config-section is used like how it currently does. This can be useful if for example the name of an AMI event is changed.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/TestRunner.py 3769 
>   /asterisk/trunk/runtests.py 3769 
> 
> Diff: https://reviewboard.asterisk.org/r/2525/diff/
> 
> 
> Testing
> -------
> 
> Set many different combinations of minversion and maxversion and used the version flag of runtests.py to simulate many different Asterisk versions. This and the logs provided the information to ensure it properly worked.
> 
> 
> Thanks,
> 
> jbigelow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130509/9a71d48c/attachment-0001.htm>