[asterisk-dev] [Code Review] 2513: Convert chan_sip.c's attended transfers to use ast_bridge_transfer_attended()

[rmudgett]

> On May 8, 2013, 11:31 p.m., Paul Belanger wrote:
> > Mostly because I am curious, why is this change needed for chan_sip? Is this for the updates to the bridging API?
> 
> rmudgett wrote:
>     Yes, that is why this is being done.
> 
> Paul Belanger wrote:
>     Does this mean anything using the bridge api would need to be updated? Or is this a nice to have?

All of the channel drivers in Asterisk 12 will need to call ast_bridge_transfer_blind() and/or ast_bridge_transfer_attended() to support transfers initiated by the channel driver's protocol (SIP, IAX2, ISDN, etc.).  The nice thing about this change for existing channel drivers is that it mostly involves deleting code.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2513/#review8520
-----------------------------------------------------------


On May 8, 2013, 7:02 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2513/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 7:02 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-21520
>     https://issues.asterisk.org/jira/browse/ASTERISK-21520
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This converts attended transfers in chan_sip.c to use ast_bridge_transfer_attended(). The majority of the change is in the local_attended_transfer() function and handle_invite_replaces().
> 
> 
> Diffs
> -----
> 
>   /team/mmichelson/sip_transfer/channels/chan_sip.c 388013 
>   /team/mmichelson/sip_transfer/channels/sip/include/sip.h 388013 
> 
> Diff: https://reviewboard.asterisk.org/r/2513/diff/
> 
> 
> Testing
> -------
> 
> Tested this by performing attended transfers with the transferer being in different states of bridging.
> * Two bridged transferer channels
> * Initially unbridged transferer to bridged transferer
> * Initially bridged transferer to unbridged transferer.
> 
> Used SIPp to send INVITE with Replaces in order to take the place of a channel. Tested this both with taking the place of bridged and unbridged channels.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130509/0802c51b/attachment.htm>