[asterisk-dev] [Code Review] 2493: Add WebSocket transport module

[Jason Parker]

> On May 8, 2013, 1:47 p.m., Matt Jordan wrote:
> > /team/group/pimp_my_sip/res/res_sip_transport_websocket.c, lines 266-268
> > <https://reviewboard.asterisk.org/r/2493/diff/1/?file=37131#file37131line266>
> >
> >     This feels like it deserves a WARNING or an ERROR.

Nope.  This gets called for every inbound message on every type of transport.


> On May 8, 2013, 1:47 p.m., Matt Jordan wrote:
> > /team/group/pimp_my_sip/res/res_sip.exports.in, lines 35-51
> > <https://reviewboard.asterisk.org/r/2493/diff/1/?file=37127#file37127line35>
> >
> >     Is there any reason not to just export everything that begins with ast_*?

I agree, but no other modules do this.  I don't think I should change it as part of this.  It should be tackled elsewhere, IMO.


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2493/#review8481
-----------------------------------------------------------


On May 8, 2013, 4:13 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2493/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 4:13 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-20952
>     https://issues.asterisk.org/jira/browse/ASTERISK-20952
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds a custom WebSocket transport module.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/include/asterisk/res_sip.h 387967 
>   /team/group/pimp_my_sip/res/res_sip.c 387967 
>   /team/group/pimp_my_sip/res/res_sip.exports.in 387967 
>   /team/group/pimp_my_sip/res/res_sip/config_transport.c 387967 
>   /team/group/pimp_my_sip/res/res_sip/location.c 387967 
>   /team/group/pimp_my_sip/res/res_sip_outbound_registration.c 387967 
>   /team/group/pimp_my_sip/res/res_sip_transport_websocket.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2493/diff/
> 
> 
> Testing
> -------
> 
> Registration works, incoming (from the browser) and outgoing (to the browser) calls work, audio flows (though, I don't have a mic, so I didn't test audio that direction).
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130508/8578b682/attachment-0001.htm>