[asterisk-dev] [Code Review] 2464: chan_gulp tests: Tests authentication failures for off nominal incoming call paths

[opticron]

> On May 2, 2013, 10:33 a.m., opticron wrote:
> > /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/playback_with_initial_sdp.xml, line 95
> > <https://reviewboard.asterisk.org/r/2464/diff/1/?file=36337#file36337line95>
> >
> >     This is invalid XML (flagged by reviewboard as well).
> 
> jbigelow wrote:
>     The double quote is part of the regex which throws things off but is valid.

Yes, but \" is not how you escape quotes in XML.  You could change the enclosing quotes to single quotes to avoid having to escape it or you could use "&quot;".


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2464/#review8425
-----------------------------------------------------------


On April 23, 2013, 9:30 a.m., jbigelow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2464/
> -----------------------------------------------------------
> 
> (Updated April 23, 2013, 9:30 a.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test sends various calls to res_sip for which authentication is expected to fail. This covers test #2 of the off-nominal paths listed on the test plan page of the wiki. It sends the wrong username, password, and *realm using IPv4/IPv6 and UDP/TCP. 
> 
> A small change was made to sipp.py to allow injection files to reside and be found in the sipp sub directory of the test directory.
> 
> * The realm is simply changed and the response digest is not recalculated in the Authorization header due to SIPp limitations.
> 
> 
> Diffs
> -----
> 
>   /asterisk/team/group/pimp_my_sip/lib/python/asterisk/sipp.py 3734 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/modules.conf PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/res_sip.conf PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/credentials-wrong_pass.csv PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/credentials-wrong_realm.csv PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/credentials-wrong_user.csv PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/playback_with_initial_sdp.xml PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/test-config.yaml PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/tests.yaml PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/configs/ast1/modules.conf PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/configs/ast1/res_sip.conf PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/credentials-wrong_pass.csv PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/credentials-wrong_realm.csv PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/credentials-wrong_user.csv PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/playback_with_initial_sdp.xml PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/test-config.yaml PRE-CREATION 
>   /asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/tests.yaml 3734 
> 
> Diff: https://reviewboard.asterisk.org/r/2464/diff/
> 
> 
> Testing
> -------
> 
> * Ensured that all 24 combinations fail as expected.
> 
> 
> Thanks,
> 
> jbigelow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130508/78f6441c/attachment-0001.htm>