[asterisk-dev] [Code Review] 2471: Basic res_sip XML documentation

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2471/#review8486
-----------------------------------------------------------



trunk/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16379>

    Red blob.



trunk/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16382>

    This shouldn't be in endpoint.



trunk/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16383>

    Same here.



trunk/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16385>

    Same here.



trunk/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16388>

    This is an implementation detail and should be removed.



trunk/res/res_sip.c
<https://reviewboard.asterisk.org/r/2471/#comment16393>

    This isnt a valid field for the contact config object.



trunk/res/res_sip_acl.c
<https://reviewboard.asterisk.org/r/2471/#comment16394>

    Red blob.


- opticron


On May 8, 2013, 8:56 a.m., Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2471/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 8:56 a.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21668
>     https://issues.asterisk.org/jira/browse/ASTERISK-21668
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Start of XML documentation for res_sip, not complete but a start.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/confbridge/conf_config_parser.c 387348 
>   trunk/res/res_sip.c 387348 
>   trunk/res/res_sip_acl.c 387348 
>   trunk/res/res_sip_endpoint_identifier_ip.c 387348 
>   trunk/res/res_sip_outbound_registration.c 387348 
> 
> Diff: https://reviewboard.asterisk.org/r/2471/diff/
> 
> 
> Testing
> -------
> 
> Ran xmllint - no errors.
> No warnings about missing XML during asterisk startup.
> 
> 
> Thanks,
> 
> Brad Latus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130508/4fb67c1a/attachment-0001.htm>