[asterisk-dev] [Code Review] 2471: Basic res_sip XML documentation

[Brad Latus]

> On April 25, 2013, 3:58 p.m., Mark Michelson wrote:
> > team/group/pimp_my_sip/res/res_sip.c, line 52
> > <https://reviewboard.asterisk.org/r/2471/diff/1/?file=36406#file36406line52>
> >
> >     s/primay/primary/

probably still haven't fixed..


> On April 25, 2013, 3:58 p.m., Mark Michelson wrote:
> > team/group/pimp_my_sip/res/res_sip.c, lines 52-55
> > <https://reviewboard.asterisk.org/r/2471/diff/1/?file=36406#file36406line52>
> >
> >     You don't actually have to configure a transport for an endpoint to be able to communicate. The transport just selects which of the configured transports to use when communicating with the endpoint. If you don't select one, then we'll just go with the first one that works.
> >     
> >     You do have to configure at least one transport section in res_sip.conf in order for Asterisk to actually be able to send and receive SIP traffic, but that is different from the transport option for endpoints.

Still not 're-fixed'.. will be in v3 i guess..


- Brad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2471/#review8352
-----------------------------------------------------------


On May 8, 2013, 1:56 p.m., Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2471/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 1:56 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21668
>     https://issues.asterisk.org/jira/browse/ASTERISK-21668
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Start of XML documentation for res_sip, not complete but a start.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/confbridge/conf_config_parser.c 387348 
>   trunk/res/res_sip.c 387348 
>   trunk/res/res_sip_acl.c 387348 
>   trunk/res/res_sip_endpoint_identifier_ip.c 387348 
>   trunk/res/res_sip_outbound_registration.c 387348 
> 
> Diff: https://reviewboard.asterisk.org/r/2471/diff/
> 
> 
> Testing
> -------
> 
> Ran xmllint - no errors.
> No warnings about missing XML during asterisk startup.
> 
> 
> Thanks,
> 
> Brad Latus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130508/93875992/attachment.htm>