[asterisk-dev] [Code Review] 2471: Basic res_sip XML documentation

[Brad Latus]

> On April 25, 2013, 4:07 p.m., Joshua Colp wrote:
> > team/group/pimp_my_sip/res/res_sip.c, line 183
> > <https://reviewboard.asterisk.org/r/2471/diff/1/?file=36406#file36406line183>
> >
> >     s/determine NATness/help traverse NAT/

Fix coming in v3..


> On April 25, 2013, 4:07 p.m., Joshua Colp wrote:
> > team/group/pimp_my_sip/res/res_sip.c, lines 312-323
> > <https://reviewboard.asterisk.org/r/2471/diff/1/?file=36406#file36406line312>
> >
> >     NAT hook is an internal implementation detail. It is not configurable and should not be documented or visible.

need a way to hide/ignore requiring XML documentation for sip sorcery objects in order not to detail some XML


- Brad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2471/#review8354
-----------------------------------------------------------


On May 8, 2013, 1:56 p.m., Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2471/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 1:56 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21668
>     https://issues.asterisk.org/jira/browse/ASTERISK-21668
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Start of XML documentation for res_sip, not complete but a start.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/confbridge/conf_config_parser.c 387348 
>   trunk/res/res_sip.c 387348 
>   trunk/res/res_sip_acl.c 387348 
>   trunk/res/res_sip_endpoint_identifier_ip.c 387348 
>   trunk/res/res_sip_outbound_registration.c 387348 
> 
> Diff: https://reviewboard.asterisk.org/r/2471/diff/
> 
> 
> Testing
> -------
> 
> Ran xmllint - no errors.
> No warnings about missing XML during asterisk startup.
> 
> 
> Thanks,
> 
> Brad Latus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130508/c10ac003/attachment-0001.htm>