[asterisk-dev] [Code Review] 2503: Ensure res_sip SRTP support parses multiple crypto attributes properly

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2503/#review8483
-----------------------------------------------------------

Ship it!


Only a minor comment. Hooray for testing!


team/group/pimp_my_sip/res/res_sip_sdp_rtp.c
<https://reviewboard.asterisk.org/r/2503/#comment16376>

    If we're going to ignore a crypto line, we should log out that we did so. That will help debugging why Asterisk responds with an answer different than what the offerer expected.


- Matt Jordan


On May 6, 2013, 6:13 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2503/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 6:13 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21416
>     https://issues.asterisk.org/jira/browse/ASTERISK-21416
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This was found when writing additional tests for https://reviewboard.asterisk.org/r/2482/
> 
> Chan_sip currently ignores crypto lines it doesn't understand so that it can find one that it can use and this allows res_sip to do the same.
> 
> 
> Diffs
> -----
> 
>   team/group/pimp_my_sip/res/res_sip_sdp_rtp.c 387765 
> 
> Diff: https://reviewboard.asterisk.org/r/2503/diff/
> 
> 
> Testing
> -------
> 
> Ran the referenced tests.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130508/e101cc2d/attachment.htm>