[asterisk-dev] [Code Review] 2428: Add channel event distribution to app_stasis

David Lee reviewboard at asterisk.org
Tue May 7 16:05:47 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2428/#review8475
-----------------------------------------------------------



trunk/main/manager_channels.c
<https://reviewboard.asterisk.org/r/2428/#comment16357>

    else if would also work.



trunk/apps/app_userevent.c
<https://reviewboard.asterisk.org/r/2428/#comment16356>

    You'll need to document in the CHANGES file how the handling of UserEvent app (name: value format required, no duplicate names, etc.)


- David Lee


On May 7, 2013, 9:53 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2428/
> -----------------------------------------------------------
> 
> (Updated May 7, 2013, 9:53 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21180
>     https://issues.asterisk.org/jira/browse/ASTERISK-21180
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add publication of AMI-equivalent channel event messages to users of app_stasis using JSON blobs.
> 
> 
> Diffs
> -----
> 
>   trunk/res/stasis_http/resource_sounds.h 387791 
>   trunk/res/stasis_http/resource_recordings.h 387791 
>   trunk/res/stasis_http/resource_events.h 387791 
>   trunk/res/res_stasis_websocket.c 387791 
>   trunk/res/res_stasis_http_events.c 387791 
>   trunk/res/res_stasis.c 387791 
>   trunk/main/stasis_channels.c 387791 
>   trunk/main/manager_channels.c 387791 
>   trunk/main/astobj2.c 387791 
>   trunk/include/asterisk/stasis_channels.h 387791 
>   trunk/apps/app_userevent.c 387791 
>   trunk/include/asterisk/astobj2.h 387791 
>   trunk/rest-api-templates/asterisk_processor.py 387791 
>   trunk/rest-api-templates/event_function_decl.mustache PRE-CREATION 
>   trunk/rest-api-templates/res_stasis_http_resource.c.mustache 387791 
>   trunk/rest-api-templates/stasis_http_resource.h.mustache 387791 
>   trunk/rest-api-templates/swagger_model.py 387791 
>   trunk/rest-api/api-docs/events.json 387791 
> 
> Diff: https://reviewboard.asterisk.org/r/2428/diff/
> 
> 
> Testing
> -------
> 
> Tested with a hacked together app_stasis app which dumps incoming messages.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130507/61cdffe2/attachment-0001.htm>


More information about the asterisk-dev mailing list