[asterisk-dev] [Code Review] 2469: Prevent duplication of XML blobs throughout documentation

Jason Parker reviewboard at asterisk.org
Tue May 7 14:23:25 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2469/#review8470
-----------------------------------------------------------



trunk/Makefile
<https://reviewboard.asterisk.org/r/2469/#comment16348>

    Don't use ls (use $(wildcard ...) if possible).
    Use $(GREP).
    Do the new aux-*.xml files in doc/ get cleaned up?
    sort -u
    Can $x and $y be more descriptive?


- Jason Parker


On May 7, 2013, 7:09 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2469/
> -----------------------------------------------------------
> 
> (Updated May 7, 2013, 7:09 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Create a minimal framework for automatically generating customized XML blobs.  Currently, this is targeted at channel snapshot XML blobs since a variant with a "Dest" suffix for every parameter name is required, but there will soon be other variants that pop up with the parking code (Retreiver, Parker, Parkee) and there is at least one variant used for bridge snapshot XML blobs during bridge merges (to which this work is trivially applicable).
> 
> 
> Diffs
> -----
> 
>   trunk/main/manager_channels.c 387801 
>   trunk/Makefile 387801 
>   trunk/doc/fragments/channel_snapshot.xml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2469/diff/
> 
> 
> Testing
> -------
> 
> Verified that documentation is generated and dumped correctly.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130507/9060307a/attachment.htm>


More information about the asterisk-dev mailing list