[asterisk-dev] [Code Review] 2469: Prevent duplication of XML blobs throughout documentation

[opticron]

> On May 2, 2013, 3:38 p.m., David Lee wrote:
> > trunk/Makefile, lines 439-441
> > <https://reviewboard.asterisk.org/r/2469/diff/1/?file=36395#file36395line439>
> >
> >     Rather than have a root /xml directory (which could mean anything), this should probably be a /doc/fragments/ or /doc/includes/ or /doc/include-templates/ or something that's at least descriptive.

Moved to doc/fragments.


> On May 2, 2013, 3:38 p.m., David Lee wrote:
> > trunk/Makefile, line 442
> > <https://reviewboard.asterisk.org/r/2469/diff/1/?file=36395#file36395line442>
> >
> >     Some of the event docs only show up in full-en_US.xml, right? Just scanning core-en_US.xml may miss some.

Updated to build the files whenever full-en_US.xml is built as well.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2469/#review8438
-----------------------------------------------------------


On April 24, 2013, 5:21 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2469/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 5:21 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Create a minimal framework for automatically generating customized XML blobs.  Currently, this is targeted at channel snapshot XML blobs since a variant with a "Dest" suffix for every parameter name is required, but there will soon be other variants that pop up with the parking code (Retreiver, Parker, Parkee) and there is at least one variant used for bridge snapshot XML blobs during bridge merges (to which this work is trivially applicable).
> 
> 
> Diffs
> -----
> 
>   trunk/Makefile 386420 
>   trunk/main/manager_channels.c 386420 
>   trunk/xml/channel_snapshot.xml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2469/diff/
> 
> 
> Testing
> -------
> 
> Verified that documentation is generated and dumped correctly.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130507/5d6a7578/attachment.htm>