[asterisk-dev] [Code Review] 2499: Fix Segfault In app_queue When "persistentmembers" Is Enabled And Using Realtime

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2499/#review8454
-----------------------------------------------------------

Ship it!


Argh. I think this one is my fault. The fix seems appropriate as well. Thanks for handling this Michael.

- jrose


On May 6, 2013, 3:07 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2499/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 3:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21738
>     https://issues.asterisk.org/jira/browse/ASTERISK-21738
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When the "ignorebusy" setting was deprecated, we added some code to allow us to be compatible with older setups that are still using the "ignorebusy" setting instead of "ringinuse".  We set a char *variable with the column name to use, which helps the realtime functions to use the correct column in their SQL queries.  When "persistentmembers" is enabled, we are not setting this variable before the realtime functions were called to load members.  This results in the variable being NULL and therefore causing a segfault when loading members during the module's process of loading.
> 
> The solution was to move the code that sets that variable to be before these realtime functions are called during the loading of the module.
> 
> 
> Diffs
> -----
> 
>   /branches/11/apps/app_queue.c 387094 
> 
> Diff: https://reviewboard.asterisk.org/r/2499/diff/
> 
> 
> Testing
> -------
> 
> Reporter tested this patch and reported back successful results.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130506/c8150399/attachment.htm>