[asterisk-dev] [Code Review] 2500: Fix The Payload Being Set On CN Packets And Do Not Set Marker Bit

[Michael Young]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2500/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-21246
    https://issues.asterisk.org/jira/browse/ASTERISK-21246


Repository: Asterisk


Description
-------

When we send out a CN packet (for instance, in the case of using rtpkeepalives), we are not setting the payload code properly.  Also, we are setting the marker bit when we shouldn't be.

AST_RTP_CN is not defined by AST_FORMAT codes.  Therefore, we should be using ast_rtp_codecs_payload_code() rather than ast_rtp_codecs_payload_lookup().

11 and trunk already use the appropriate function.

If I am understanding the RFC correctly, the marker bit should not be set to on when sending a CN packet.  This part will be fixed in 11 and trunk.


Diffs
-----

  /branches/1.8/res/res_rtp_asterisk.c 386529 

Diff: https://reviewboard.asterisk.org/r/2500/diff/


Testing
-------

The reporter tested this patch, providing pcaps and debugging to confirm that the packets are being set correctly.  This also resolved his audio distortion problems since the payload that was being set on the packet was ULAW (instead of CN).   He was using the ALAW codec and unless there was a re-negotiation of codecs, the user would experience audio problems after one of these rtpkeepalives were sent by Asterisk.

I also tested by looking at pcaps of packets being sent properly on dev machine.


Thanks,

Michael Young

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130506/235f36ab/attachment-0001.htm>