[asterisk-dev] [Code Review] 2482: Add tests for SDP SRTP negotiation

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2482/#review8431
-----------------------------------------------------------



asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/configs/ast1/modules.conf
<https://reviewboard.asterisk.org/r/2482/#comment16262>

    This shouldn't be necessary.
    
    1. The Test Suite build agents create a modules.conf for pimp_my_sip, that should load the necessary modules. If they don't load them, they need to be updated there. You should be able to edit the pimp_my_sip build plan to add res_sip_sdp_rtp.
    
    2. By the time this gets merged into the main test suite branch, it shouldn't have its own modules.conf



asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/test-config.yaml
<https://reviewboard.asterisk.org/r/2482/#comment16261>

    In general, our test descriptions need to start getting a bit more verbose. Ideally, these will eventually get pushed up to the Asterisk wiki as documentation for what is tested, and "tests scenarios" isn't terribly descriptive.
    
    It's worthwhile noting what scenarios are tested, i.e.,
     * A nominal scenario with a single key
     * Off-nominal where a request contains a key but encryption support is disabled
     * Off-nominal where a request does not contain a key but encryption support is enabled
    
    etc.


Some additional scenarios are needed here.

1. Multiple keys with different lifetimes (AES_CM_128_HMAC_SHA1_32/AES_CM_128_HMAC_SHA1_128)
2. Off-nominal - bad key formattings provided (no family, no ordering numbers, etc.)
3. Key lifetimes. We don't support it, but pjproject probably will parse it out. If a key lifetime is supported, we should reject the offer. (At least, that's what happens today)


- Matt Jordan


On April 29, 2013, 8:58 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2482/
> -----------------------------------------------------------
> 
> (Updated April 29, 2013, 8:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21416
>     https://issues.asterisk.org/jira/browse/ASTERISK-21416
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Add tests for SRTP negotiation in SDP for cases where:
> * Call declined
> ** Encryption enabled
> *** Unknown cryptographic suite in offer
> *** Missing crypto attribute in offer
> *** Encryption not offered (attribute present)
> ** Encryption not enabled
> * Call accepted
> ** Encryption not enabled, crypto attribute present and ignored
> ** Encryption enabled
> 
> 
> Diffs
> -----
> 
>   asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/configs/ast1/modules.conf PRE-CREATION 
>   asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/configs/ast1/res_sip.conf PRE-CREATION 
>   asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/accept_disabled_with_attrib.xml PRE-CREATION 
>   asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/accept_nominal.xml PRE-CREATION 
>   asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_enabled.xml PRE-CREATION 
>   asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_no_attrib.xml PRE-CREATION 
>   asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_not_enabled.xml PRE-CREATION 
>   asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_unknown_suite.xml PRE-CREATION 
>   asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/test-config.yaml PRE-CREATION 
>   asterisk/team/group/pimp_my_sip/tests/channels/gulp/tests.yaml 3735 
> 
> Diff: https://reviewboard.asterisk.org/r/2482/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130502/42588f57/attachment-0001.htm>