[asterisk-dev] [Code Review] 2490: stasis: Swap out network_change events for network_change stasis messages sent to a new 'system' topic.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2490/#review8428
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On May 2, 2013, 4:49 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2490/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 4:49 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee, kmoore, and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21103
>     https://issues.asterisk.org/jira/browse/ASTERISK-21103
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> A continuation of the effort started with https://reviewboard.asterisk.org/r/2481
> 
> This one replaces the NETWORK_CHANGE events. I added the system topic and it is stored in/is registed by asterisk.c at startup.
> It's worth noting that NETWORK_CHANGE events had no data associated with them before. Since generating stasis messages ao2_refs the
> data going in, some ao2_object has to be included, so I went ahead and gave it a blank JSON object wrapped in a json_payload similar
> to how I handled the ACL change messages.
> 
> Part 2/3
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk.h 387420 
>   /trunk/channels/chan_sip.c 387420 
>   /trunk/channels/chan_iax2.c 387420 
>   /trunk/main/asterisk.c 387420 
>   /trunk/main/event.c 387420 
>   /trunk/res/res_stun_monitor.c 387420 
> 
> Diff: https://reviewboard.asterisk.org/r/2490/diff/
> 
> 
> Testing
> -------
> 
> Since the only thing that generates these messages under normal conditions is res_stun_monitor and I don't really know how to or particularly want to set up a stun server, I simply used a test function that would generate the messages in the same way as they are when the STUN monitor would issue them. I made sure that each of the consumers (which are just chan_sip and chan_iax2) reacted to the messages as anticipated and they did.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130502/af2ae2e2/attachment.htm>