[asterisk-dev] [Code Review] 2483: IAX2 Blind Transfers Support using New API

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2483/#review8411
-----------------------------------------------------------

Ship it!



/team/mmichelson/transfer/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2483/#comment16230>

    While there's certainly no requirement to do so, you could use RAII_VAR here:
    
    RAII_VAR(struct ast_channel *, owner, ast_channel_ref(iaxs[fr->callno]->owner), ast_channel_unref);
    
    This way, if exit points were to be added to this case for whatever reason, we'd be insured against the possibility of an accidental channel reference leak.


- Mark Michelson


On May 1, 2013, 4:13 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2483/
> -----------------------------------------------------------
> 
> (Updated May 1, 2013, 4:13 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change moves chan_iax2 to using the new API as done by Mark for blind transfers.
> 
> 
> Diffs
> -----
> 
>   /team/mmichelson/transfer/channels/chan_iax2.c 386859 
> 
> Diff: https://reviewboard.asterisk.org/r/2483/diff/
> 
> 
> Testing
> -------
> 
> Connected to another Asterisk over IAX2, used Transfer application, confirmed blind transfer happens as expected.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130501/6c60e113/attachment.htm>