[asterisk-dev] [Code Review] 2488: SIP Session-Expires: Set timer to correctly expire at (~2/3) of the expiry interval when not the refresher.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2488/#review8410
-----------------------------------------------------------

Ship it!


Thanks for citing the RFC in the source!


branches/11/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2488/#comment16229>

    Can replace with 
    
    else {
        timeout_ms -= MIN(timeout_ms / 3, 32000);
    }


- Mark Michelson


On May 1, 2013, 8:31 p.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2488/
> -----------------------------------------------------------
> 
> (Updated May 1, 2013, 8:31 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21742
>     https://issues.asterisk.org/jira/browse/ASTERISK-21742
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> RFC 4028 Section 10
> 
> 	if the side not performing refreshes does not receive a
> 	session refresh request before the session expiration, it SHOULD send
> 	a BYE to terminate the session, slightly before the session
> 	expiration.  The minimum of 32 seconds and one third of the session
> 	interval is RECOMMENDED.
> 
> 
> Diffs
> -----
> 
>   branches/11/channels/sip/include/sip.h 386925 
>   branches/11/channels/chan_sip.c 386925 
> 
> Diff: https://reviewboard.asterisk.org/r/2488/diff/
> 
> 
> Testing
> -------
> 
> asterisk to phone.
> Phone's Session-Expires: 120
> 
> [Apr 30 22:49:20] NOTICE[12686][C-00000000]: chan_sip.c:29006 start_session_timer: Session timer started: 104 - 50a7397219b8f47e192f74e81f3b125e at 192.168.x.y:5060 88000ms
> <<<<<  pull ethernet on phone >>
> <<<<<  88 seconds later       >>
> [Apr 30 22:50:48] WARNING[12686]: chan_sip.c:29042 proc_session_timer: Session-Timer expired - 50a7397219b8f47e192f74e81f3b125e at 192.168.x.y:5060
> 
> 
> Phone to Asterisk, No Session-Expires
> Asterisk's Session-Expires: 300
> [Apr 30 23:47:02] NOTICE[12857][C-00000001]: chan_sip.c:29006 start_session_timer: Session timer started: 99 - 7160947918a9977c at 192.168.124.73 150000ms
> 
> 
> Thanks,
> 
> Alec Davis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130501/29180175/attachment.htm>