[asterisk-dev] [Code Review] 2489: Address unload order issues for res_stasis* modules

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2489/
-----------------------------------------------------------

(Updated May 1, 2013, 1:04 p.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

Missed a usecount bump from app_stasis.


Repository: Asterisk


Description
-------

I've noticed when doing a graceful shutdown that the res_stasis_http.so
module gets unloaded before the modules that use it, which causes some
asserts during their unload.

While r386928 was a quick hack to get it to not assert and die, this
patch increases the use counts on res_stasis.so and res_stasis_http.so
properly. It's a bigger change than I expected, hence the review instead
of just committing it.


Diffs (updated)
-----

  /trunk/apps/app_stasis.c 386989 
  /trunk/include/asterisk/stasis_app.h 386989 
  /trunk/main/loader.c 386989 
  /trunk/res/res_stasis.c 386989 
  /trunk/res/res_stasis_http.c 386989 
  /trunk/res/res_stasis_http_asterisk.c 386989 
  /trunk/res/res_stasis_http_bridges.c 386989 
  /trunk/res/res_stasis_http_channels.c 386989 
  /trunk/res/res_stasis_http_endpoints.c 386989 
  /trunk/res/res_stasis_http_events.c 386989 
  /trunk/res/res_stasis_http_playback.c 386989 
  /trunk/res/res_stasis_http_recordings.c 386989 
  /trunk/res/res_stasis_http_sounds.c 386989 
  /trunk/res/res_stasis_websocket.c 386989 
  /trunk/rest-api-templates/res_stasis_http_resource.c.mustache 386989 
  /trunk/tests/test_res_stasis.c 386989 

Diff: https://reviewboard.asterisk.org/r/2489/diff/


Testing
-------

Checked unload order when running core stop gracefully.


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130501/a446f79e/attachment.htm>