[asterisk-dev] [Code Review] 2418: Fix parallel make problems

Shaun Ruffell reviewboard at asterisk.org
Fri Mar 29 09:43:16 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2418/#review8154
-----------------------------------------------------------

Ship it!


Ship It!

- Shaun Ruffell


On March 28, 2013, 9:48 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2418/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 9:48 p.m.)
> 
> 
> Review request for Asterisk Developers and Shaun Ruffell.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Occasionally, make -j would fail due to missing includes, or other
> unusual errors.
> 
> This was due to the 'cleantest' target, which was designed to force a
> make clean when some change in the code would cause the typical
> depedency checking to fail. Several targets in the main Makefile did
> not depend upon cleantest, hence would run in parallel to it. By
> adding the dependency, make -j runs happily now.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/Makefile 384301 
> 
> Diff: https://reviewboard.asterisk.org/r/2418/diff/
> 
> 
> Testing
> -------
> 
> sruffel ran 13 make -j10 builds which failed consistently before the patch, and worked fine afterwards.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130329/9ddefb35/attachment.htm>


More information about the asterisk-dev mailing list