[asterisk-dev] [Code Review] 2416: Refactor snapshot diff AMI event generation to route through Stasis via channel blobs

opticron reviewboard at asterisk.org
Wed Mar 27 18:13:24 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2416/
-----------------------------------------------------------

(Updated March 27, 2013, 6:13 p.m.)


Review request for Asterisk Developers and David Lee.


Changes
-------

Added note about code that really shouldn't be in manager_channels.c


Bugs: ASTERISK-21180
    https://issues.asterisk.org/jira/browse/ASTERISK-21180


Repository: Asterisk


Description (updated)
-------

This builds off the work in dlee's stasis-app branch (on reviewboard: https://reviewboard.asterisk.org/r/2361/ ) to make channel snapshot difference analysis a more generic process that creates channel blob messages which can then be consumed by AMI, app_stasis, and other interfaces.  This also puts in place a framework for handling those messages for AMI and app_stasis and exposes functionality necessary to create channel blobs and publish them to the appropriate channel topics without needing the channel itself.

Note: The channel blob generation that currently lives in manager_channels.c really should not be there and will be moving elsewhere very shortly.


Diffs
-----

  team/dlee/stasis-app/main/manager_channels.c 384219 
  team/dlee/stasis-app/main/channel.c 384219 
  team/dlee/stasis-app/main/channel_internal_api.c 384219 
  team/dlee/stasis-app/include/asterisk/channel.h 384219 
  team/dlee/stasis-app/apps/app_userevent.c 384219 
  team/dlee/stasis-app/apps/app_stasis.c 384219 

Diff: https://reviewboard.asterisk.org/r/2416/diff/


Testing
-------

Run under the testsuite for several tests that use the majority of the refactored AMI events.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130327/e74de7b0/attachment-0001.htm>


More information about the asterisk-dev mailing list